Removed lingering remnants of old app diff feature #35652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These buttons were both removed in #24220
orangejenny
requested review from
millerdev,
MartinRiese,
gherceg and
jingcheng16
MartinRiese
approved these changes
Jan 22, 2025
| @@ -4795,10 +4795,6 @@ jsbn@~0.1.0: | |||
| resolved "https://registry.yarnpkg.com/jsbn/-/jsbn-0.1.1.tgz#a5e654c2e5a2deb5f201d96cefbca80c0ef2f513" | |||
| integrity sha1-peZUwuWi3rXyAdls77yoDA7y9RM= | |||
|
|
|||
| jsdiff@components/jsdiff#~3.2.0: | |||
There was a problem hiding this comment.
🥳 the less the merrier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Discovered while working on app manager migration to webpack.
This feature was rewritten in #24220
Bonus, this removes the jsdiff library from HQ, which is one of the few remaining bower-only libraries, so this PR gets us a step closer to getting off of yarn.
Safety Assurance
Safety story
Dead code removal. Code review is a sufficient safety check.
Automated test coverage
Deletes relevant tests.
QA Plan
No.
Rollback instructions
Labels & Review