Ran prettify over app manager's base templates

[orangejenny]

Technical Summary

Prep for migrating app manager to webpack

Safety Assurance

Safety story

Automated linting changes

Automated test coverage

no

QA Plan

Not requesting QA

Rollback instructions

• This PR can be reverted after deploy with no further considerations

Labels & Review

• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[nospame]

It seems like this type of whitespace changes on the {% blocktrans %} tags is probably what's causing the errors in tests. I'm honestly quite annoyed that Prettier is even trying to format here, but the issue seems to be that it's treating anything inside <script> tags differently from the rest of the file, forcing a different parser than the jinja-template plugin we have set up for HTML file... which then results in different (broken) formatting inside the <script> tags.

[nospame]

Turning off the embedded-language-formatting option should in theory be the way to fix it, however it is instead resulting in blanking out the entire file (maybe because jinja/django tags look like an "embedded" language).

[nospame]

There's a somewhat ugly option here, which is using html comments to ignore the sections that use django template tags inside of script tags (because that seems to be what's causing issues). The syntax for this is specific to the parser, so using prettier-plugin-jinja-template it looks like this:

<!-- prettier-ignore-start -->
<script type="text/html">
  ...
</script>
<!-- prettier-ignore-end -->

https://github.com/davidodenwald/prettier-plugin-jinja-template?tab=readme-ov-file#ignoring-code

[orangejenny]

Interesting, thank you for investigating. I'd rather not ignore everything inside of script tags, since they do contain HTML and in theory should be formatted. I played around with this and have a few more thoughts:

1. Changing the type on the script block from text/html to text/template also seems to tell prettier not to format the contents, so basically a more concise (but less explicit) version of the comments. But I don't like this for the same reason: this content ought to get formatted.
2. Another option could be to move the template content into a separate file and then include it. If the script tags are in the outer file and only the inner content is in the included file, prettify won't know it's a script block and ought to format it normally.
3. Yet another option is to increase allowed line length, which doesn't fix this problem directly but generally makes prettify make fewer changes. I think 80 is too short, especially because it's shorter than our python limit. A 115-character limit would have allowed the original code to pass by unmodified.

I read through the full diff (which I had not previously done, but now I know it's important to skim the prettify changes) and made a couple changes in 1957b44