Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fill model properties from ReferencesMany relationship #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fill model properties from ReferencesMany relationship #241

wants to merge 1 commit into from

Conversation

alltouch
Copy link
Collaborator

@alltouch alltouch commented Aug 6, 2017 •
edited by digitalsadhu
Loading

ReferencesMany keys are stored in relationship. Move them to model props before save

TODO

  • Add test case

@alltouch alltouch requested a review from digitalsadhu August 6, 2017 22:10
@alltouch alltouch force-pushed the referencesMany-move-to-props branch from cfd5c49 to 2180d13 Compare August 6, 2017 22:14
@coveralls
Copy link

coveralls commented Aug 6, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.9%) to 92.714% when pulling 2180d13 on referencesMany-move-to-props into 42ede51 on master.

digitalsadhu
digitalsadhu requested changes Aug 7, 2017
View reviewed changes
Copy link
Owner

@digitalsadhu digitalsadhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks good to me. I like the refactoring into belongsToRelation and referencesManyRelation.

Would you be able to add a test case for references many?

@digitalsadhu
Copy link
Owner

@alltouch Any chance you could add a test case for this so we can get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalsadhu digitalsadhu digitalsadhu requested changes

Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alltouch @coveralls @digitalsadhu