Update README with modern pagination helper #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
While something similar could easily be done to handle token-based pagination, there is only a single function which uses this approach so the existing example is sufficient. |
Instead of requiring consumers of godo to hand-craft separate wrapper functions for each paginated List* function, demonstrate how to use golang generics to write a single helper. Additionally, use the slices pattern to avoid wasteful memory usage buffering responses, and demonstrate how this can also work for List* functions which require an additional argument.
Author
|
@SSharma-10 you merged the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring consumers of godo to hand-craft separate wrapper functions for each paginated List* function, demonstrate how to use golang generics to write a single helper.
Additionally, use the slices pattern to avoid wasteful memory usage buffering responses, and demonstrate how this can also work for List* functions which require an additional argument.
Fixes #861