Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset load speed up #484

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Dataset load speed up #484

wants to merge 4 commits into from

Conversation

dale-wahl
Copy link
Member

Really just a refactoring of DataSet.children attribute to a DataSet.get_children() method. It is particularly helpful with datasets that have many children with their own children since loading any dataset would automatically load all its children (and thus all of their children). Now they are only loaded if needed. (Biggest effect I see is in the results page speed on my local 4CAT.)

This also ensures the children are current when running certain methods (e.g. copy_ownership_from) that would update those children (previously they may not have been updated if they were created after a DataSet object was instantiated).

It does remove the is_finished filter that was previously applied to the DataSet.children attribute , but, so far as I can tell, that was never necessary where the attribute is used.

Also includes a debug time_this method which is only active when in debug mode. Could be applied elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant