Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really just a refactoring of
DataSet.children
attribute to aDataSet.get_children()
method. It is particularly helpful with datasets that have many children with their own children since loading any dataset would automatically load all its children (and thus all of their children). Now they are only loaded if needed. (Biggest effect I see is in the results page speed on my local 4CAT.)This also ensures the children are current when running certain methods (e.g.
copy_ownership_from
) that would update those children (previously they may not have been updated if they were created after a DataSet object was instantiated).It does remove the
is_finished
filter that was previously applied to theDataSet.children
attribute , but, so far as I can tell, that was never necessary where the attribute is used.Also includes a debug
time_this
method which is only active when in debug mode. Could be applied elsewhere.