Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand 4cat to other languages (Finnish) #470

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

anitabraida
Copy link

These are the changes proposed in this pull request:

Wordlists added:

  1. Finnish hatespeech wordlist (no offensiveness scores available)
  2. Finnish wordlist with common vocabulary

Processors changed:

  1. lexical_filter. Added Finnish hatespeech, introduced choice for the user to select the language. If the language selected is a highly inflected one (in this case, Finnish), it gives the user the option to choose between exact word match (present previously) and subword match (added in this pull request).
  2. wikipedia_network. Added the option to find Wikipedia links in a Finnish language dataset.
  3. neologisms. Added the Finnish wordlist with common vocabulary. The user has now the option to choose either English (default) or Finnish as the language. Pipeline changed accordingly.
  4. tokenise. Added Finnish wordlist with common vocabulary for the filter. Added a lemmatization option for Finnish (uses SpaCy).
  5. similar_words (presets). Included additional information.

In the setup, SpaCy is included again to allow for lemmatization on Finnish text.

anitabraida and others added 30 commits September 13, 2024 12:13
@matnel
Copy link

matnel commented Mar 1, 2025

@ErikBorra @stijn-uva Would be lovely if you could check and merge this soonish! :) Please let me know if there are any issues with the code, happy to patch this PR.

@dale-wahl
Copy link
Member

@sal-uva you removed spacy last year. I cannot recall or find what the specific issue was and only vaguely remember some dependency problems. Do you recall?

@sal-uva
Copy link
Collaborator

sal-uva commented Mar 3, 2025

@sal-uva you removed spacy last year. I cannot recall or find what the specific issue was and only vaguely remember some dependency problems. Do you recall?

There were some dependency problems (iirc it didn't like our version of NumPy) and because of its resource-heavy nature was only suited for small-scale datasets for (among others) entity recognition, which can now be done much better with LLMs.

But if it's handy for Finnish and it doesn't cause any dependency errors for you, all good to add back in!

@matnel
Copy link

matnel commented Mar 4, 2025

I think we did not encounter issues, but happy to test more if that helps - any hints on what to test out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants