Release 6.9.8 #1492
Merged
Release 6.9.8 #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This https://github.com/digital-preservation/droid/pull/1165/files is causing DROID to report wrong signatures. It needs to be reverted.
* The last modified date from S3 wasn't being set. * If you ran the file identification on a single file, it was returning the folder as well. * The window size for S3 identification was always 4Mb, even if the maxBytesToScan was less. It now uses whichever value is smaller. * There were no tests for the S3EventHandler. Outside of S3 identification, since the Java upgrade, the call to the PRONOM SOAP API was failing. It was missing a dependency which I've added in.
We're calling headObject to get the file size and last modified but that isn't necessary as we've already got that information from when we list the objects. This should speed things up as we're not making unnecessary API calls.
sparkhi
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.