Skip to content

Commit

Permalink
change default of refills todays logs to true (#27)
Browse files Browse the repository at this point in the history
* changes default of refills todays logs to true

* regenerate-log-override -> False

* removes refill-todays-log button
  • Loading branch information
CarlosCoelhoSL authored Feb 4, 2025
1 parent 4f02274 commit 414fe8c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 2 additions & 4 deletions dags/collection_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@
"transformed-jobs": Param(default=8, type="integer"),
"dataset-jobs": Param(default=8, type="integer"),
"incremental-loading-override": Param(default=False, type="boolean"),
"regenerate-log-override": Param(default=True, type="boolean"),
"refill-todays-logs": Param(default=False, type="boolean"),
"regenerate-log-override": Param(default=False, type="boolean"),
},
render_template_as_native_obj=True,
is_paused_upon_creation=False,
Expand Down Expand Up @@ -94,8 +93,7 @@
{"name": "TRANSFORMED_JOBS", "value":"'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"transformed-jobs\") | string }}'"},
{"name": "DATASET_JOBS", "value": "'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"dataset-jobs\") | string }}'"},
{"name": "INCREMENTAL_LOADING_OVERRIDE", "value": "'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"incremental-loading-override\") | string }}'"},
{"name": "REGENERATE_LOG_OVERRIDE", "value": "'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"regenerate-log-override\") | string }}'"},
{"name": "REFILL_TODAYS_LOGS", "value": "'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"refill-todays-logs\") | string }}'"}
{"name": "REGENERATE_LOG_OVERRIDE", "value": "'{{ task_instance.xcom_pull(task_ids=\"configure-dag\", key=\"regenerate-log-override\") | string }}'"}
],
},
]
Expand Down
2 changes: 0 additions & 2 deletions dags/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ def configure_dag(**kwargs):
dataset_jobs = str(kwargs['params'].get('dataset-jobs'))
incremental_loading_override = bool(kwargs['params'].get('incremental-loading-override'))
regenerate_log_override = bool(kwargs['params'].get('regenerate-log-override'))
refill_todays_logs = bool(kwargs['params'].get('refill-todays-logs'))

# get ecs-task logging configuration
ecs_client = boto3.client('ecs')
Expand All @@ -117,6 +116,5 @@ def configure_dag(**kwargs):
ti.xcom_push(key='collection-dataset-bucket-name', value=collection_dataset_bucket_name)
ti.xcom_push(key='incremental-loading-override', value=incremental_loading_override)
ti.xcom_push(key='regenerate-log-override', value=regenerate_log_override)
ti.xcom_push(key='refill-todays-logs', value=refill_todays_logs)

return configure_dag

0 comments on commit 414fe8c

Please sign in to comment.