Skip to content

Conversation

@Girik1105
Copy link
Contributor

@Girik1105 Girik1105 commented Jun 20, 2025

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

Display of references on slides

references should be in apa format

VSPC-276

Anything else the reviewer needs to know?

... describe here ...

@diging-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@diging-jenkins
Copy link

Can one of the admins verify this patch?

import java.util.regex.Matcher;
import java.util.regex.Pattern;

public class CitationFormatter {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about what this class is for. We don't have in text citations, just a list of references, so we don't need any in-text citation formatting.

*/
@Override
@Transient
public String htmlRenderedText() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the citations are in a biblio block, not a text block. So I don't think this is right.

@jdamerow jdamerow closed this Oct 17, 2025
@jdamerow
Copy link
Member

I think you misunderstood the ticket. This is for the biblio blocks, not the text blocks.

@Girik1105 Girik1105 reopened this Oct 23, 2025
Copy link
Member

@jdamerow jdamerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use the class in the 150 branch.

@jdamerow jdamerow closed this Nov 7, 2025
@Girik1105 Girik1105 reopened this Nov 7, 2025
@Girik1105 Girik1105 closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants