-
Notifications
You must be signed in to change notification settings - Fork 3
story/VSPC-276 #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
story/VSPC-276 #356
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class CitationFormatter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about what this class is for. We don't have in text citations, just a list of references, so we don't need any in-text citation formatting.
| */ | ||
| @Override | ||
| @Transient | ||
| public String htmlRenderedText() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the citations are in a biblio block, not a text block. So I don't think this is right.
|
I think you misunderstood the ticket. This is for the biblio blocks, not the text blocks. |
jdamerow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should use the class in the 150 branch.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
Display of references on slides
references should be in apa format
VSPC-276
Anything else the reviewer needs to know?
... describe here ...