new feature: edit artist images - #1169
Merged
digimezzo merged 80 commits intoJul 26, 2026
Merged
Conversation
… generic name to be used for both, artist and album artwork
# Conflicts: # src/app/common/application/i18n.spec.ts # src/app/data/database-migrator.ts # src/app/services/indexing/indexing.service.spec.ts # src/app/services/indexing/indexing.service.ts # src/assets/i18n/pt-PT.json
…to feature/artist-image-editing # Conflicts: # src/assets/i18n/pt-PT.json
# Conflicts: # src/app/app.module.ts # src/app/common/api/fanart/fanart.api.ts # src/app/common/application/i18n.spec.ts # src/app/data/database-migrator.ts # src/app/data/migrations/migration11.ts # src/app/data/repositories/artist-artwork-repository.base.ts # src/app/data/repositories/artist-artwork-repository.spec.ts # src/app/data/repositories/artist-artwork-repository.ts # src/app/services/artist/artist-splitter.spec.ts # src/app/services/artist/artist-splitter.ts # src/app/services/artist/artist.service.spec.ts # src/app/services/artist/artist.service.ts # src/app/services/dialog/dialog.service.base.ts # src/app/services/dialog/dialog.service.ts # src/app/services/indexing/artist-artwork-adder.spec.ts # src/app/services/indexing/artist-artwork-adder.ts # src/app/services/indexing/indexing.service.spec.ts # src/app/services/indexing/indexing.service.ts # src/app/services/indexing/online-artist-artwork-getter.spec.ts # src/app/services/indexing/online-artist-artwork-getter.ts # src/app/ui/components/collection/collection-artists/artist-browser/artist-browser.component.spec.ts # src/app/ui/components/collection/collection-artists/artist-browser/artist-browser.component.ts # src/app/ui/components/collection/collection-artists/artist/artist.component.html # src/app/ui/components/collection/collection-artists/artist/artist.component.scss # src/app/ui/components/manage-collection/manage-albums/manage-albums.component.html # src/assets/i18n/ar.json # src/assets/i18n/bg.json # src/assets/i18n/cs.json # src/assets/i18n/de.json # src/assets/i18n/el.json # src/assets/i18n/en.json # src/assets/i18n/es.json # src/assets/i18n/fa.json # src/assets/i18n/fr.json # src/assets/i18n/he.json # src/assets/i18n/hr.json # src/assets/i18n/it.json # src/assets/i18n/ja-JP.json # src/assets/i18n/ko.json # src/assets/i18n/ku.json # src/assets/i18n/nl.json # src/assets/i18n/pl.json # src/assets/i18n/pt-BR.json # src/assets/i18n/pt-PT.json # src/assets/i18n/ru.json # src/assets/i18n/sv.json # src/assets/i18n/tr.json # src/assets/i18n/vi.json # src/assets/i18n/zh-CN.json # src/assets/i18n/zh-TW.json
Owner
|
@FranzDeschler Thank you! This looks great. i'll review it very soon. I see that I accidentally closed it today when pushing a commit using the wrong id. So if you wondered why this was, that's the reason 😝. PR is now re-opened. |
# Conflicts: # src/assets/i18n/bg.json # src/assets/i18n/pt-PT.json # src/assets/i18n/zh-CN.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an addition to the "show artist images" feature. It allows the user to edit the artist images.
In case "show artist images" is enabled, the context menu of the artist entries contains an "Edit..." option.
That button opens the "Edit artist" dialog.
Here, the user can remove the artist image or select a custom one from the local computer. This works the same way as when editing album covers. The dialog also provides the possibility to search for images online. This functionality uses the fanart API which usually provides multiple images for an artist. The user can select one of those images afterwards.
If no images could be found online, a corresponding dialog is shown.
No AI
I used AI to do the translations. Everything else is 100% human intelligence ;-)
To clarify
Similar to the "edit album cover" functionality, this feature uses a "IsManuallySet" flag in the database. This flag is set to "1" if the user chooses a local image or selects one of the images found online. If the user deletes the image, the flag stays "0". That way, removed images are loaded again when pressing "refresh all" in the settings.
How does this work for the album covers? Should a deleted artist image be treated as manually set?