new feature: show artist image as background - #1161
Merged
digimezzo merged 60 commits intoJul 25, 2026
Merged
Conversation
… generic name to be used for both, artist and album artwork
# Conflicts: # package-lock.json # src/app/app.module.ts # src/app/services/indexing/indexing.service.spec.ts # src/app/services/indexing/indexing.service.ts # src/app/ui/components/manage-collection/manage-collection.component.html # src/assets/i18n/he.json
# Conflicts: # src/app/common/application/i18n.spec.ts # src/app/data/database-migrator.ts # src/app/services/indexing/indexing.service.spec.ts # src/app/services/indexing/indexing.service.ts # src/assets/i18n/pt-PT.json
… into feature/artist-image-background
# Conflicts: # src/app/app.module.ts # src/app/common/application/i18n.spec.ts # src/app/data/database-migrator.ts # src/app/data/migrations/migration11.ts # src/app/data/repositories/artist-artwork-repository.base.ts # src/app/data/repositories/artist-artwork-repository.spec.ts # src/app/data/repositories/artist-artwork-repository.ts # src/app/services/artist/artist-splitter.spec.ts # src/app/services/artist/artist-splitter.ts # src/app/services/artist/artist.service.spec.ts # src/app/services/artist/artist.service.ts # src/app/services/indexing/indexing.service.spec.ts # src/app/services/indexing/indexing.service.ts # src/app/ui/components/collection/album-browser/album-browser.component.ts # src/app/ui/components/collection/collection-artists/artist-browser/artist-browser.component.ts # src/app/ui/components/collection/collection-artists/artist/artist.component.html # src/app/ui/components/collection/collection-artists/artist/artist.component.scss # src/app/ui/components/manage-collection/manage-albums/manage-albums.component.html # src/assets/i18n/ar.json # src/assets/i18n/bg.json # src/assets/i18n/cs.json # src/assets/i18n/de.json # src/assets/i18n/el.json # src/assets/i18n/en.json # src/assets/i18n/es.json # src/assets/i18n/fa.json # src/assets/i18n/fr.json # src/assets/i18n/he.json # src/assets/i18n/hr.json # src/assets/i18n/it.json # src/assets/i18n/ja-JP.json # src/assets/i18n/ko.json # src/assets/i18n/ku.json # src/assets/i18n/nl.json # src/assets/i18n/pl.json # src/assets/i18n/pt-BR.json # src/assets/i18n/pt-PT.json # src/assets/i18n/ru.json # src/assets/i18n/sv.json # src/assets/i18n/tr.json # src/assets/i18n/vi.json # src/assets/i18n/zh-CN.json # src/assets/i18n/zh-TW.json
FranzDeschler
changed the title
Owner
|
@FranzDeschler Thank you! Another great PR 😉 I'll review it soon. |
Owner
|
@FranzDeschler I just tested out your branch and the content of the genres tab seems to be unresponsive here. Do you have the same behaviour on your side? |
Contributor
Author
|
@digimezzo yes I have the same behaviour. Indeed the background element I added is the reason. I will try to fix that as soon as possible. |
Contributor
Author
|
@digimezzo I added a condition so the artist background element is only visible in the "Artists" tab. |
Owner
|
@FranzDeschler Amazing work! Thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an addition to the "show artist images" feature.
When a single artist is selected, the artist image is displayed as background in the album section.
To clarify: