Skip to content

remove texinfo and edit rst #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 19, 2025
Merged

remove texinfo and edit rst #276

merged 8 commits into from
Mar 19, 2025

Conversation

ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Mar 18, 2025

close #274

@ycexiao
Copy link
Contributor Author

ycexiao commented Mar 18, 2025

It should pay extra attention to balance between making it easy to read for beginners and making it comprehensive to look up for experienced users. The old manual is only designed for experienced users so it may need extra editing to tailor it.

Here is just a draft about how to move and re-organize the previous content in the old manual.

TOC of the old manual
image

TOC of the new manual
image

Previous version of the new manual had only Tutorials and 3 lessons in it. PDFgui layout is extracted from Section 2 in the old manual. Lesson 3: Calculating ... is inserted. Examples and Extras are modified from the Section 3 and 4 in the old manual.

@ycexiao ycexiao marked this pull request as ready for review March 18, 2025 04:15
@ycexiao
Copy link
Contributor Author

ycexiao commented Mar 18, 2025

New manual
image

Old manual
image

@ycexiao
Copy link
Contributor Author

ycexiao commented Mar 18, 2025

@sbillinge It's ready for review.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (b17fb6f) to head (7acfe73).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          23       23           
  Lines        1123     1123           
=======================================
  Hits         1068     1068           
  Misses         55       55           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great @ycexiao, exactly what we want. Congratulations!

I left a few small comments inline, but when these are fixed I think this can be merged and closed.

============================================ ===============================
AtomEyeAtomEye structure viewer, XCFG format http://li.mit.edu/A/Graphics/A/
============================================ ===============================
PyMOLPyMOL structure viewer, PDB format https://www.pymol.org
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the preferred one these days is VESTA. Would it be possible for you to test using VESTA in this role and then adding that (and possibly removing atomeye and pymol, or at least determinging if they are still maintained packages? Leave them if htey are, but put VEST top.

update. I took a quick look and it seems that atomeye is not supported. I suggest we drop mention of atomeye, put vesta top but leave pymol (which is still supported...it is owned by schrodinger now)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried VESTA. It works
image


**Removed:**

* <news item>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to mention the manual is removed

@@ -0,0 +1,23 @@
**Added:**

* <news item>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention tutorial info from the old manual is added to the online docs

PDFgui layout
=============

First, Open ``pdfgui``. Instructions for doing this depend on your system, but an example would be to open a terminal, activate your pdfgui conda environment, and type ``pdfgui`` at the prompt, or to double-click a project file on windows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open -> open

@ycexiao
Copy link
Contributor Author

ycexiao commented Mar 18, 2025

@sbillinge It's ready for review.

@sbillinge sbillinge merged commit c5fa048 into diffpy:main Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: remove texinfo
2 participants