Fix for multiple morphs #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 96.85% 96.87% +0.02%
==========================================
Files 18 18
Lines 795 801 +6
==========================================
+ Hits 770 776 +6
Misses 25 25
🚀 New features to boost your workflow:
|
sbillinge
reviewed
Dec 8, 2024
|
Yes, tests needed. I think adding 2 directories with blank files to testsequence is sufficient if the tests still pass as there is no specific output given when directories are parsed out. |
|
Tests pass. Good to merge? |
sbillinge
reviewed
Feb 10, 2025
| @@ -0,0 +1 @@ | |||
| This directory should be ignored by PDFmorph. | |||
There was a problem hiding this comment.
can we not do it with tmpdir dynamically in the test? We normally wouldn't do it this way by creating junk in the source repo.
|
Closing for fresh bugfix branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to break for multiple subdirectories within the many-morphs directories.