Add user details dialog to admin panel #285
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| const { | ||
| data: userDetails, | ||
| isLoading: isLoadingDetails, | ||
| refetch: refetchUserDetails, | ||
| } = api.admin.getUserDetails.useQuery( | ||
| { | ||
| adminToken, | ||
| privyDid: selectedUser?.privyDid || '', | ||
| }, | ||
| { | ||
| enabled: !!selectedUser && isUserDetailsOpen && isTokenValid, | ||
| retry: false, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
The user details dialog doesn't handle error states from the tRPC query, potentially showing "No details available" for both failed requests and legitimately empty data.
View Details
📝 Patch Details
diff --git a/packages/web/src/app/(public)/admin/page.tsx b/packages/web/src/app/(public)/admin/page.tsx
index 81411614..9148031d 100644
--- a/packages/web/src/app/(public)/admin/page.tsx
+++ b/packages/web/src/app/(public)/admin/page.tsx
@@ -69,6 +69,7 @@ export default function AdminPage() {
const {
data: userDetails,
isLoading: isLoadingDetails,
+ error: userDetailsError,
refetch: refetchUserDetails,
} = api.admin.getUserDetails.useQuery(
{
@@ -221,6 +222,10 @@ export default function AdminPage() {
{isLoadingDetails ? (
<div className="py-8 text-center">Loading user details...</div>
+ ) : userDetailsError ? (
+ <div className="py-8 text-center text-red-600">
+ Error loading user details: {userDetailsError.message}
+ </div>
) : userDetails ? (
<div className="space-y-6">
<Card>
Analysis
Admin panel user details dialog lacks error handling for failed tRPC queries
What fails: api.admin.getUserDetails.useQuery() in admin page doesn't extract or handle error state, causing all failure scenarios to show generic "No details available" message
How to reproduce:
- Open admin panel and click on a user to view details
- Trigger any error condition (invalid admin token, network failure, server error)
- Dialog shows "No details available" instead of specific error message
Result: All error conditions (network failures, authorization errors, server errors) are indistinguishable from legitimate empty data cases
Expected: Show specific error messages when tRPC queries fail per TanStack Query error handling docs - useQuery returns error property for failed requests
Root cause: Query hook only destructures data, isLoading, refetch but omits error property. Conditional rendering only checks loading and data states.
- Add getUserDetails tRPC procedure to fetch user info, workspace, and features - Show savings enabled status with color indicator - Display primary workspace name and memberships - Include user role, features list, and account status
benjaminshafii
force-pushed
the
feat/admin-user-details
branch
from
69d6f6c to
6b69cd7
Compare
Summary
Add user details dialog to admin panel for easier debugging
Changes
Info Displayed