fix(automations): keep nested workspace jobs visible#1391
Closed
fix(automations): keep nested workspace jobs visible#1391
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workdirby falling back from exact matches to related parent/child workspace rootsapps/server/src/scheduler.test.tsand Rust unit tests inapps/desktop/src-tauri/src/commands/scheduler.rsCurrent vs expected behavior
workdir; if a job was created at/Users/jan/Programming/the-cloud-factory, opening/Users/jan/Programming/the-cloud-factory/_repos/openworkhides it completelyBefore and after
These screenshots use the real local scheduler jobs on this machine with a nested selected workspace root of
/Users/jan/Programming/the-cloud-factory/_repos/openwork.Before
After
Validation
pnpm --filter openwork-server test -- ./src/scheduler.test.tspnpm --filter openwork-server build:bincargo test scheduler::tests --libinapps/desktop/src-tauricargo check --libinapps/desktop/src-tauribun -e '...'against real local scheduler job JSONs to confirm the existing automations stay visible for/Users/jan/Programming/the-cloud-factory,/Users/jan/Programming/the-cloud-factory/_repos/openwork, and/Users/jan/Programming/the-cloud-factory/_repos/openwork/apps/appUI verification blocker
packaging/docker/dev-up.sh, but the dev stack failed before the web UI became availableshareexited during dependency setup withENOTEMPTY: directory not empty, rmdir '/app/node_modules/.pnpm'orchestratorfailed withERR_PNPM_ENOTEMPTY: ENOTEMPTY: directory not empty, rmdir '/app/node_modules/.pnpm/[email protected]/node_modules/dayjs'