SystemVerilog: discover package dependencies in expressions and types #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the change to the cbmc submodule intentional? |
kroening
force-pushed
the
verilog-package-dep
branch
from
5d925d2 to
35cb0c3
Compare
|
Fixed |
tautschnig
approved these changes
Feb 7, 2025
src/verilog/verilog_expr.cpp
Outdated
Comment on lines
89
to
99
| if(expr.id() == ID_verilog_package_scope) | ||
| { | ||
| auto &package_scope_expr = to_verilog_package_scope_expr(expr); | ||
| dest.push_back( | ||
| verilog_package_identifier(package_scope_expr.package_base_name())); | ||
| } | ||
| else | ||
| { | ||
| for(auto &op : expr.operands()) | ||
| dependencies_rec(op, dest); | ||
| } |
There was a problem hiding this comment.
In the interest of reducing (or: not further increasing) the use of recursion when traversing expressions (which at times is causing stack overflows for us): can we please use an expr iterator here:
for(const_depth_iteratort it = expr.depth_cbegin(); it != expr.depth_cend(); ++it)
{
if(it->id() == ID_verilog_package_scope)
{
auto &package_scope_expr = to_verilog_package_scope_expr(*it);
dest.push_back(
verilog_package_identifier(package_scope_expr.package_base_name()));
}
}
Dependencies on a package via the package scope operator :: are now discovered when used in types or expressions.
kroening
force-pushed
the
verilog-package-dep
branch
from
35cb0c3 to
6e562d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies on a package via the package scope operator
::are now discovered when used in types or expressions.