BMC: return property handles/literals #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
Jan 17, 2025
src/trans-netlist/unwind_netlist.cpp
Outdated
Comment on lines
151
to
152
| bvt prop_bv; | ||
| prop_bv.resize(bmc_map.timeframe_map.size()); |
There was a problem hiding this comment.
Suggested change
| bvt prop_bv; | |
| prop_bv.resize(bmc_map.timeframe_map.size()); | |
| bvt prop_bv{bmc_map.timeframe_map.size()}; |
or perhaps use .reserve instead of .resize and use .push_back in the loop below.
src/trans-word-level/property.cpp
Outdated
Comment on lines
698
to
699
| exprt::operandst prop_handles; | ||
| prop_handles.resize(no_timeframes, true_exprt()); |
There was a problem hiding this comment.
Suggested change
| exprt::operandst prop_handles; | |
| prop_handles.resize(no_timeframes, true_exprt()); | |
| exprt::operandst prop_handles{no_timeframes, true_exprt()}; |
The property handles/literals for the BMC time frames are now returned as return values, as opposed to being returned via a reference. This removes the ambiguity about what should happen when there are values in those vectors prior to the call.
kroening
force-pushed
the
prop_handles
branch
from
8da771d to
4700fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property handles/literals for the BMC time frames are now returned as return values, as opposed to being returned via a reference.
This removes the ambiguity about what should happen when there are values in those vectors prior to the call.