SMV: set pretty names for top-level identifiers #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
smvlang-pretty-names
branch
from
d1674c9 to
5728a30
Compare
|
Rebase required to resolve conflicts. |
Identifiers in module main now no longer carry the prefix main::var::.
kroening
force-pushed
the
smvlang-pretty-names
branch
from
5728a30 to
3ec49b5
Compare
|
done |
tautschnig
approved these changes
Apr 23, 2024
| bool type2smv(const typet &type, std::string &code); | ||
|
|
||
| bool expr2smv(const exprt &, std::string &code, const namespacet &); | ||
| bool type2smv(const typet &, std::string &code, const namespacet &); |
There was a problem hiding this comment.
Not for this PR, but rather asking about potential future work: Is bool really the appropriate return type? Shouldn't places that return true really be using UNIMPLEMENTED instead? Then the return type could instead be std::string.
There was a problem hiding this comment.
Another option would be to send anything that that code doesn't know how to format to format_expr.
Comment on lines
+175
to
+176
| symbol_tablet symbol_table; | ||
| namespacet ns(symbol_table); |
There was a problem hiding this comment.
Do we really not have a symbol table or namespace available when invoking show_parse?
There was a problem hiding this comment.
Yes, this is pre typechecking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifiers in module main now no longer carry the prefix
main::var::.