Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include text preceeding special case emojis, include ™ symbol in excluded emojis #2502

Merged

Conversation

DominikMeca
Copy link
Contributor

This PR fixes an issue where text fragments containing a special case symbol (trademark/copyright symbol) would get replaced with just the symbol. It also adds a new excluded symbol (™).

Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: a30bcfe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@react-pdf/layout Patch
@react-pdf/renderer Patch
@react-pdf/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@diegomura diegomura changed the title Include text preceeding special case emojis, include ™ symbol in excluded emojis feat: include text preceeding special case emojis, include ™ symbol in excluded emojis Jan 17, 2024
Copy link
Owner

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Thanks!

@diegomura diegomura merged commit 96ea576 into diegomura:master Jan 17, 2024
1 check passed
mskec pushed a commit to mskec/react-pdf that referenced this pull request Feb 26, 2024
…n excluded emojisxcluded emojis (diegomura#2502)

* Include text preceeding special case emojis, include ™ symbol in excluded emojis

* Create sharp-mirrors-taste.md

---------

Co-authored-by: Diego Muracciole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants