Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resume Repl Example #143

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bdkopen
Copy link
Contributor

@bdkopen bdkopen commented Oct 11, 2024

  • Update the Resume repl example to use the working example originally provided in the react-pdf repo.

Deployment preview: https://react-pdf-git-fork-bdkopen-fix-resume-example-diegomuracciole.vercel.app//repl?example=resume

Fixes issue: #138

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-pdf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 3:52am
site-7bsx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 3:52am

@bdkopen bdkopen marked this pull request as ready for review October 11, 2024 02:21
@diegomura
Copy link
Owner

Doc looks broken to me in url 😕

@bdkopen
Copy link
Contributor Author

bdkopen commented Jan 11, 2025

Sorry for the delay here, @diegomura! Ready for re-review.

I fixed the text overflowing and caught a few other spelling issues. Also made a few more Star Wars trivia corrections.

@diegomura
Copy link
Owner

Screenshot 2025-01-11 at 12 00 15 AM

Header paddings look odd to me. And also right alignment on the resume entries

@bdkopen
Copy link
Contributor Author

bdkopen commented Jan 11, 2025

@diegomura ready to go again.

I realized that this template was originally from the react-pdf repo (source). Rather than trying to fix all the styling here to try and make it look alright, I think it makes a lot more sense to just pull that working example directly in here.

I consolidated the multiple files into this one. The only modification was renaming the component styles variables to more specific ones like headerStyles.

Since the original example renders three pages with different @media layouts, this example will now demonstrate that too!

You can compare the rendered output to these snapshots (here, here, and here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants