-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Resume Repl Example #143
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Doc looks broken to me in url 😕 |
Sorry for the delay here, @diegomura! Ready for re-review. I fixed the text overflowing and caught a few other spelling issues. Also made a few more Star Wars trivia corrections. |
@diegomura ready to go again. I realized that this template was originally from the react-pdf repo (source). Rather than trying to fix all the styling here to try and make it look alright, I think it makes a lot more sense to just pull that working example directly in here. I consolidated the multiple files into this one. The only modification was renaming the component Since the original example renders three pages with different You can compare the rendered output to these snapshots (here, here, and here). |
Deployment preview: https://react-pdf-git-fork-bdkopen-fix-resume-example-diegomuracciole.vercel.app//repl?example=resume
Fixes issue: #138