-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vault integration - features - fetch credentials of RabbitMQ from vault #25
Open
namankhurpia
wants to merge
8
commits into
master
Choose a base branch
from
feature-develop-vaultintegration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1da2681
Job termination implementation
e985f40
gdrivebug
sowbhagyaveera c7a754d
Merge pull request #21 from didclab/origin/sv/gdrivebug
jgoldverg d0777be
Merge pull request #22 from didclab/JobTermination
jgoldverg 208f1a3
adding vault integration code to fetch credentials
namankhurpia 1381c3f
Revert "adding vault integration code to fetch credentials"
namankhurpia a77f5e0
adding vault integration code to fetch credential
namankhurpia 114c2fc
remove token
namankhurpia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
src/main/java/com/rabbitMq/rabbitmqscheduler/DTO/Properties.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package com.rabbitMq.rabbitmqscheduler.DTO; | ||
|
||
import lombok.Data; | ||
import org.springframework.beans.factory.annotation.Value; | ||
import org.springframework.boot.context.properties.ConfigurationProperties; | ||
|
||
@Data | ||
@ConfigurationProperties("ods") | ||
public class Properties { | ||
|
||
String AMPQ_PWD; | ||
String AMPQ_USER; | ||
|
||
} |
10 changes: 10 additions & 0 deletions
10
src/main/java/com/rabbitMq/rabbitmqscheduler/DTO/StopRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package com.rabbitMq.rabbitmqscheduler.DTO; | ||
|
||
import lombok.Data; | ||
|
||
@Data | ||
public class StopRequest { | ||
Long jobId; | ||
String transferNodeName; | ||
|
||
} |
19 changes: 19 additions & 0 deletions
19
src/main/java/com/rabbitMq/rabbitmqscheduler/DTO/StopResponses.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package com.rabbitMq.rabbitmqscheduler.DTO; | ||
|
||
public class StopResponses { | ||
private boolean success; | ||
private String errorMessage; | ||
|
||
public StopResponses(boolean success, String errorMessage) { | ||
this.success = success; | ||
this.errorMessage = errorMessage; | ||
} | ||
|
||
public boolean isSuccess() { | ||
return success; | ||
} | ||
|
||
public String getErrorMessage() { | ||
return errorMessage; | ||
} | ||
} |
3 changes: 3 additions & 0 deletions
3
src/main/java/com/rabbitMq/rabbitmqscheduler/RabbitmqSchedulerApplication.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wont be able to accept this PR b/c the secret is embedded in the yaml file There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed and token revoked |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
spring: | ||
application: | ||
name: RabbitmqSchedulerApplication | ||
cloud: | ||
vault: | ||
scheme: https | ||
host: 'vault.onedatashare.org' | ||
port: 443 | ||
token: <place_token_here> | ||
authentication: token | ||
kv: | ||
enabled: true | ||
profile-separator: '/' | ||
default-context : RabbitmqSchedulerApplication | ||
backend: secret | ||
profiles: application_properties |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why u r using @DaTa here.