Fix and add favorite unit test #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfianyusufabdullah
requested changes
Apr 2, 2021
There was a problem hiding this comment.
Pelajari step menentukan skenario di sini https://github.com/wajahatkarim3/Imagine
|
|
||
| @Test | ||
| fun setReadModule() { | ||
| val dummy = DataDummy.generateDummyModules("a")[0] |
There was a problem hiding this comment.
Ini dummy cuman buat invoke sama verify? Tambahkan assertion
There was a problem hiding this comment.
Kalau yang ini kan yang di test method void dan hanya meneruskan call saja ke repository. Jadi menurutku, disini cukup verify call method saja
https://blog.knoldus.com/unit-testing-void-methods-with-mockito-and-junit/
Atau mungkin dari mas Alfian ada cara lain kah ?
Comment on lines
57
to
64
| val dummyCourseWithModule = Resource.success(DataDummy.generateDummyCourseWithModules(dummyCourse, false)) | ||
| val course = MutableLiveData<Resource<CourseWithModule>>() | ||
| course.value = dummyCourseWithModule | ||
|
|
||
| `when`(academyRepository.getCourseWithModules(courseId)).thenReturn(course) | ||
| viewModel.courseModule.observeForever(observer) | ||
|
|
||
| val courseFromViewModel = viewModel.courseModule.value!!.data |
There was a problem hiding this comment.
Ini buat apa? Skenario berikutnya doNothing, jadi bisa langsung pakai dummyCourseWithModule saja.
|
|
||
| val courseFromViewModel = viewModel.courseModule.value!!.data | ||
|
|
||
| doNothing().`when`(academyRepository).setCourseBookmark(courseFromViewModel!!.mCourse, true) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request for update and adding favorite movies for projects 10-room-test until 12-pagination-test.