Init #1
Merged
Init #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mladedav
reviewed
Feb 12, 2025
mladedav
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Yeah, I think this looks good now.
This is personal preference, but I'd expect stderr to also contain the warn and error logs, otherwise it would be pretty hard to get the full chronological output. Basically having the full log there and the build warnings serving as an alert that something is happening.
But there's always more time to add more knobs for things like this.
Thanks, I'll add an issue to keep track of it |
nkaralis
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation for
tokio-rs/tracing#3213