Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to conan 2 #44

Merged
merged 16 commits into from
May 27, 2024
Merged

upgrade to conan 2 #44

merged 16 commits into from
May 27, 2024

Conversation

mcb5637
Copy link
Contributor

@mcb5637 mcb5637 commented May 13, 2024

No description provided.

@mcb5637 mcb5637 changed the base branch from main to develop May 13, 2024 14:09
@mcb5637 mcb5637 force-pushed the feature/conan2_new branch from 95efb62 to edc1f7c Compare May 13, 2024 14:10
@mcb5637 mcb5637 marked this pull request as ready for review May 13, 2024 14:59
@mcb5637 mcb5637 requested a review from liss-h May 13, 2024 14:59
liss-h
liss-h requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@liss-h liss-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions

@mcb5637
Copy link
Contributor Author

mcb5637 commented May 17, 2024

So, there is a conan addon for CLion. it did provide the conan_provider.cmake automatically, but i need it in the CI, thats why its here.

@mcb5637 mcb5637 requested a review from liss-h May 27, 2024 11:16
liss-h
liss-h requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@liss-h liss-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the readme is still outdated, since fetchcontent for Catch2 does not work anymore

@mcb5637 mcb5637 requested a review from liss-h May 27, 2024 12:30
liss-h
liss-h approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@liss-h liss-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just tested it and it works

@liss-h liss-h merged commit 75d7bb2 into develop May 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liss-h liss-h liss-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcb5637 @liss-h