Boundless panel intersection#43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panel::get_ray_intersectionchecks whether the computed intersectionlies within the physical extent of the panel before returning a result.
This is correct for determining whether a reflection is genuinely
recorded, but is too restrictive when the intersection is needed
regardless of whether it falls within the detector boundary, like when
computing bounding boxes.
This PR adds a companion method that performs the same
ray-to-panel-frame projection but omits the bounds check, returning the
mm coordinate for any forward-facing ray.
Panel::get_ray_intersection_unbounded, which projects s₁ intothe panel frame via D·s₁ and returns the mm intersection for any ray
with a positive depth component, without checking against
image_size_mm_.get_ray_intersectionto delegate toget_ray_intersection_unboundedand apply the bounds check on theresult, eliminating duplicated projection arithmetic.
get_ray_intersection(mmm→mm).This allows callers that previously had to replicate the projection
arithmetic inline to use the Panel API directly, while preserving the
bounds-checked behaviour of the existing method for all current calls.