Adjust network call timeout behaviors #614
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharmab
commented
Nov 11, 2025
Owner
Author
dharmab
left a comment
dharmab
left a comment
There was a problem hiding this comment.
Needs some human editing
Owner
Author
There was a problem hiding this comment.
These tests are not valuable and should be removed.
Owner
Author
There was a problem hiding this comment.
I hate this package comment, needs human rewrite.
Owner
Author
There was a problem hiding this comment.
Too many comments, needs human rewrite.
dharmab
force-pushed
the
fix/network-timeouts
branch
from
aaf1c5b to
5ed8021
Compare
dharmab
commented
Nov 12, 2025
| // OpenAIHTTPTimeout is the timeout for HTTP requests to the OpenAI API. | ||
| // Audio transcription can be slow for large files, so this is set higher | ||
| // than typical HTTP timeouts. | ||
| OpenAIHTTPTimeout = 60 * time.Second |
Owner
Author
There was a problem hiding this comment.
Should remove this and just use the standard 30s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI assisted patch, needs strict review and testing