Skip to content

Conversation

@dharmab
Copy link
Owner

@dharmab dharmab commented Oct 16, 2025

[10:58] Thursday, 19 June 2025 10:58
gcask: Heads up: with a future release of srs, we will be switching from newsoft json to dotnet's implementation.

This gives us better, faster, stronger but also stricter parsing.
For anything user facing we'll keep it lenient, but for any client/server message passing it'll be tighter.

It matters if you wrote your own "client", where you might want to double check your properties are camelCase.

(thinking about @Zaid in particular here).

The performance of srs are already pretty good and they're about to get better. More cpu time for your dcs 

[17:17] Thursday, 19 June 2025 17:17
Zaid: @gcask I've got the ClientInfo and Message structs using PascalCase and everything else using camelCase:
https://github.com/dharmab/skyeye/blob/main/pkg/simpleradio/types/info.go
https://github.com/dharmab/skyeye/blob/main/pkg/simpleradio/types/message.go

Are those changing?

[17:29] Thursday, 19 June 2025 17:29
gcask: yes! They should work fine with either case for now, but they will move towards camelCase.

if you want to build/test locally, you can use this branch for now: https://github.com/gcask/DCS-SimpleRadioStandalone/tree/system-json (PR #777 if you want to check the diffs) (waiting for the current release to settle a bit before moving forward).

Well actually it's even trickier: for the net messages, I'm not specifying the casing so it should match the property name casing for the equivalent structs in the C# code.

@dharmab
Copy link
Owner Author

dharmab commented Nov 8, 2025

Looks like this breaks SkyEye with whichever version of SRS Flashpoint Levant is using 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants