Add support for the number protocol #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: We now get warnings because of the modularization of the macro system specified in RFC rust-lang/rfcs#1561 However, fixing these warnings is out of scope for this PR.
markbt
requested changes
Aug 11, 2021
Now it mostly matches the corresponding magic methods and CAPI calls. In particular the mismatch between 'div_mod' and 'div_floor' has been annoying me in my code ;)
|
I fixed the two mistakes you noticed and changed the naming to be more consistent with the corresponding magic methods and CAPI calls. |
dgrunwald
reviewed
Sep 1, 2021
| err::result_from_owned_ptr(py, ffi::PyNumber_MatrixMultiply(self.as_ptr(), other)) | ||
| }) | ||
| } | ||
| #[cfg(any(feature = "python3-4", feature = "python2-sys"))] { |
There was a problem hiding this comment.
This feature checks if the user explicitly requested python3-4 as a cargo feature.
It won't be set when python 3.4 is instead selected via PYTHON_SYS_EXECUTABLE.
Fixing this will require solving #269 (comment) in some way.
dgrunwald
reviewed
Sep 1, 2021
| /// Throws an exception if unable to perform | ||
| /// the conversion. | ||
| #[inline] | ||
| fn as_int(&self, py: Python) -> PyResult<PyLong> { |
There was a problem hiding this comment.
Following the Rust naming conventions, to_int would be a more appropriate name -- to me, as_ implies the function returns some form of reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: We now get warnings because of the modularization of the macro system
specified in RFC rust-lang/rfcs#1561
However, fixing these warnings is out of scope for this PR.