-
Notifications
You must be signed in to change notification settings - Fork 15
feat(benchmarks): scaling, scenarios, CI quality gate, and release trend #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dgenio
wants to merge
3
commits into
main
Choose a base branch
from
claude/issue-triage-grouping-34z06s
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| name: Routing-scale smoke benchmark | ||
|
|
||
| # Non-gating, scheduled routing-scale benchmark for drift detection (issue #688, | ||
| # child of #444). Runs the deterministic routing-scale profiler on a fixed seed | ||
| # and stores its JSON as a per-run trend artifact, so scaling regressions are | ||
| # visible over time without blocking any PR. This never gates: PR-time quality | ||
| # gating lives in the main CI job (benchmarks/gating.yaml + benchmark_gate.py, #491). | ||
|
|
||
| on: | ||
| schedule: | ||
| # Tuesday 06:30 UTC — off-hours, staggered from the weekly scorecard job. | ||
| - cron: "30 6 * * 2" | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| routing-scale: | ||
| name: Routing-scale profile (non-gating) | ||
| runs-on: ubuntu-latest | ||
| # The profiler is informational; a failure must never page anyone or block work. | ||
| continue-on-error: true | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.12" | ||
|
|
||
| - name: Today | ||
| id: date | ||
| run: echo "today=$(date -u +%Y-%m-%d)" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Install dependencies | ||
| run: pip install -e ".[dev]" | ||
|
|
||
| - name: Run routing-scale profile | ||
| # Reduced sizes keep the scheduled run well under the runner timeout; | ||
| # the local `make benchmark-routing-scale` default sweeps up to 10k. | ||
| run: python benchmarks/routing_scale.py --sizes 100,1000,5000 | ||
|
|
||
| - name: Upload trend artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: routing-scale-${{ steps.date.outputs.today }} | ||
| path: | | ||
| benchmarks/results/routing_scale.json | ||
| docs/benchmarks/routing-scale.md | ||
| retention-days: 90 | ||
| if-no-files-found: error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Benchmark quality-regression gate configuration (issue #491). | ||
| # | ||
| # Turns the informational benchmark-delta PR comment (scripts/benchmark_delta.py) | ||
| # into a gating CI check: a PR that regresses a *quality* metric beyond its band | ||
| # (vs the committed benchmarks/results/latest.json baseline) fails CI. Latency | ||
| # stays informational — runner variance makes it unreliable as a gate. | ||
| # | ||
| # Band semantics (see scripts/benchmark_gate.py): | ||
| # - fraction metrics (recall_at_k / mrr / precision_at_k, range 0..1) regress | ||
| # when head < base - max_regression_pp / 100. | ||
| # - percent metrics (token_savings_pct, already 0..100) regress when | ||
| # head < base - max_regression_pp. | ||
| # | ||
| # The ~0.5pp noise floor at 200 gold queries (.github/prompts/add-eval.prompt.md) | ||
| # informs the 1.0pp quality band; token savings get a looser 2.0pp band. | ||
| quality: | ||
| recall_at_k: { max_regression_pp: 1.0 } | ||
| mrr: { max_regression_pp: 1.0 } | ||
| precision_at_k: { max_regression_pp: 1.0 } | ||
| token_savings_pct: { max_regression_pp: 2.0 } | ||
| latency: | ||
| gating: false | ||
| # A maintainer-applied PR label that downgrades a gate failure to a warning for | ||
| # intentional trade-offs (the rationale belongs in the PR description). | ||
| override_label: benchmark-accepted |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.