Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ic-http-certification): add upgrade property to HttpResponse struct #265

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat(ic-http-certification): add upgrade property to HttpResponse struct #265

merged 1 commit into from
Jan 15, 2024

Conversation

nathanosdev
Copy link
Member

@nathanosdev nathanosdev commented Jan 10, 2024 •
edited
Loading

Add the upgrade property on the HttpResponse object. Also rename Certification to HttpCertification.

@nathanosdev nathanosdev self-assigned this Jan 10, 2024
@nathanosdev nathanosdev force-pushed the nathan/add-response-upgrade-property branch from 69efc8e to 8c05bc6 Compare January 10, 2024 15:38
@nathanosdev nathanosdev changed the title Nathan/add response upgrade property feat(ic-http-certification): add upgrade property to HttpResponse struct Jan 10, 2024
@nathanosdev nathanosdev force-pushed the nathan/add-response-upgrade-property branch from 8c05bc6 to d9e27da Compare January 10, 2024 15:41
@nathanosdev nathanosdev marked this pull request as ready for review January 10, 2024 16:36
@nathanosdev nathanosdev requested a review from a team as a code owner January 10, 2024 16:36
@nathanosdev nathanosdev force-pushed the nathan/add-response-upgrade-property branch from d9e27da to 91ade30 Compare January 12, 2024 13:18
keplervital
keplervital approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@keplervital keplervital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanosdev nathanosdev force-pushed the nathan/add-response-upgrade-property branch from 91ade30 to 1152098 Compare January 15, 2024 10:36
@nathanosdev nathanosdev enabled auto-merge (rebase) January 15, 2024 10:36
@nathanosdev nathanosdev merged commit ecb8549 into main Jan 15, 2024
6 checks passed
@nathanosdev nathanosdev deleted the nathan/add-response-upgrade-property branch January 15, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keplervital keplervital keplervital approved these changes

Assignees

@nathanosdev nathanosdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanosdev @keplervital