test: use cel expression builder in response verification integration tests #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanosdev
force-pushed
the
nathan/use-cel-builder-integration-tests
branch
from
1475b61 to
6df5d3a
Compare
nathanosdev
force-pushed
the
nathan/use-cel-builder-integration-tests
branch
from
6df5d3a to
05a527f
Compare
…:dfinity/response-verification into nathan/use-cel-builder-integration-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the CEL builder in our integration tests means we have a lot less handwritten CEL expressions. Eventually I'd like to get rid of all of them except for the ones that are used to test the CEL parser and builder.
There's still a few more around, but refactoring the tests wasn't my focus. I ran into issues in these tests because of changes that are coming in another PR. The
Certificationobject fromic-http-certificationis using references now, so after integrating with that the CEL parser functions have some lifetime restrictions on their parameters that makes them difficult to work with in certain situations and it was much easier to just use the CEL builder in the tests.