feat: add copy on write support to CEL definition types #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integrating
ic-http-certificationintoic-response-verification, I ran into issues with managing lifetimes because theDefaultRequestCertificationandDefaultResponseCertificationstructs are holding references to data, instead of owning it.This causes problems when you want to return a reference to data that is owned by the current function. Using copy on write (COW) for the properties on these structs allows us to keep the advantage of holding references to data while allowing the struct to take ownership of data in those cases where it's needed.
I split this PR out from the changes in
ic-response-verificationto make the PR smaller.