Skip to content

Commit

Permalink
Revert "feat(IDX): reuse check-membership workflow (#102)"
Browse files Browse the repository at this point in the history
This reverts commit f5f67a6.
  • Loading branch information
cgundy authored Jan 27, 2025
1 parent f5f67a6 commit 7178182
Show file tree
Hide file tree
Showing 4 changed files with 61 additions and 47 deletions.
32 changes: 30 additions & 2 deletions .github/workflows/check_cla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,36 @@ on:

jobs:
check-membership:
uses: ./.github/workflows/check_membership.yml
secrets: inherit
name: Check Membership
runs-on: ubuntu-latest
# Dont run this workflow on merge queue
if: ${{ github.event_name != 'merge_group' }}
outputs:
is_member: ${{ steps.check-membership.outputs.is_member}}
steps:
- name: Create GitHub App Token
uses: actions/create-github-app-token@v1
id: app-token
with:
app-id: ${{ vars.CLA_BOT_APP_ID }}
private-key: ${{ secrets.CLA_BOT_PRIVATE_KEY }}

- name: Checkout
uses: actions/checkout@v4
with:
repository: 'dfinity/public-workflows'

- name: Python Setup
uses: ./.github/workflows/python-setup

- name: Check Membership
id: check-membership
run: python reusable_workflows/check_membership/check_membership.py
shell: bash
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
GH_ORG: ${{ github.repository_owner }}
USER: ${{ github.event.pull_request.user.login }}

check-external-contributions:
name: Check External Contributions
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check_cla_ruleset.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ on:

jobs:
call-check-cla:
uses: .github/workflows/check_cla.yml
uses: dfinity/public-workflows/.github/workflows/check_cla.yml@main
secrets: inherit
42 changes: 0 additions & 42 deletions .github/workflows/check_membership.yml

This file was deleted.

32 changes: 30 additions & 2 deletions .github/workflows/internal_vs_external.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,36 @@ permissions:

jobs:
check-membership:
uses: ./.github/workflows/check_membership.yml
secrets: inherit
name: Check Membership
runs-on: ubuntu-latest
# Dont run this workflow on merge queue
if: ${{ github.event_name != 'merge_group' }}
outputs:
is_member: ${{ steps.check-membership.outputs.is_member}}
steps:
- name: Create GitHub App Token
uses: actions/create-github-app-token@v1
id: app-token
with:
app-id: ${{ vars.CLA_BOT_APP_ID }}
private-key: ${{ secrets.CLA_BOT_PRIVATE_KEY }}

- name: Checkout
uses: actions/checkout@v4
with:
repository: 'dfinity/public-workflows'

- name: Python Setup
uses: ./.github/workflows/python-setup

- name: Check Membership
id: check-membership
run: python reusable_workflows/check_membership/check_membership.py
shell: bash
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
GH_ORG: ${{ github.repository_owner }}
USER: ${{ github.event.pull_request.user.login }}

revoke-approvals:
name: Revoke Approvals
Expand Down

0 comments on commit 7178182

Please sign in to comment.