Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(crypto): CRP-2599 add smoke test for VetKdProtocol impl #3649

Open
wants to merge 4 commits into
base: franzstefan/CRP-2599-vetkdprotocol-impl
Choose a base branch
from

Conversation

fspreiss
Copy link
Member

Adds smoke tests for the VetKdProtocol trait implementation added in #3565

@fspreiss fspreiss marked this pull request as ready for review January 28, 2025 13:23
@fspreiss fspreiss requested a review from a team as a code owner January 28, 2025 13:23
@randombit randombit self-requested a review January 29, 2025 14:59
Copy link
Contributor

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

randombit

This comment was marked as duplicate.

@fspreiss fspreiss requested review from a team as code owners January 29, 2025 16:51
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

@fspreiss fspreiss removed request for a team January 29, 2025 17:03
@fspreiss fspreiss removed request for a team January 29, 2025 17:04
@fspreiss fspreiss dismissed github-actions[bot]’s stale review January 29, 2025 17:05

No canister behavior changes.

@fspreiss
Copy link
Member Author

@fspreiss fspreiss requested review from [world]

Sorry for the noise! Had to do some git acrobatics to solve an issue for IDX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants