Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Log guestos.service console logs to tty1 #3645

Merged
merged 8 commits into from
Jan 28, 2025

Conversation

andrewbattat
Copy link
Member

@andrewbattat andrewbattat commented Jan 28, 2025

ICSUP-3863

This fixes the "blank console" issue where, after completing a successful SetupOS installation, HostOS starts the guestos service, the console is cleared as QEMU is launched, and then node providers just see a blank console like:
image

This PR fixes this error so that now, the start-guestos script pipes failure logs from the virsh start guestos command to the console:
Pasted Graphic 5

Also adds an onboarding message for the success case:
image

@andrewbattat andrewbattat self-assigned this Jan 28, 2025
@github-actions github-actions bot added the feat label Jan 28, 2025
@andrewbattat andrewbattat marked this pull request as ready for review January 28, 2025 18:10
@andrewbattat andrewbattat requested a review from a team as a code owner January 28, 2025 18:10
@github-actions github-actions bot added the @node label Jan 28, 2025
@andrewbattat andrewbattat added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit c05b185 Jan 28, 2025
28 checks passed
@andrewbattat andrewbattat deleted the andrew/guestos-service-console-logs branch January 28, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants