refactor(nns-governance): Delete *_voting_power fields from governance.proto. #3643
Conversation
daniel-wong-dfinity-org
changed the base branch from
master
to
delete-neuron-info-from-governance-proto-daniel-wong
daniel-wong-dfinity-org
force-pushed
the
delete-voting-power-fields-from-governance-proto-daniel-wong
branch
8 times, most recently
from
c05002c to
bccde58
Compare
…overnance.proto. These are derived, and therefore, do not need to be stored in stable memory. They are part of the API though, so we do not remove them from governance.did.
…information is needed to perform this conversion. Specifically, in order to populate the deciding_voting_power field, VotingPowerEconomics is needed. Also deleted transcribing from *_voting_power fields in the other direction.
…ecause we deleted that in a recent commit. Resurrected `impl From<Neuron> for NeuronProto`, which replaces `into_proto`, which is no longer needed, because converting to NeuronProto no longer requires auxiliary data (used to calculate *_voting_power fields that have been deleted). Still need to implement convertion to API Neuron. That will be done in next commit. //rs/nns/governance builds 🤘
…fix affected tests, it was simply a matter of instead using pb::Neuron::from.
…ing *_voting_power fields from NNS governance.proto).
daniel-wong-dfinity-org
force-pushed
the
delete-voting-power-fields-from-governance-proto-daniel-wong
branch
2 times, most recently
from
8fe714c to
be7b682
Compare
…ng, which (again, IMHO) is per usual.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
No canister behavior change. Just a refactor.
| // we are using a circular buffer to store them. This solution is not ideal, but | ||
| // we need to do a larger refactoring to use the correct API types instead of the internal | ||
| // governance proto at this level. | ||
| proto.recent_ballots = neuron.sorted_recent_ballots(); |
There was a problem hiding this comment.
Hmm. I may have forgotten to replace this... Not sure why this was done outside of conversion... That also seems like a mistake...
There was a problem hiding this comment.
It should be added to the conversion, definitely. It wasn't added in the conversion b/c it didn't seem possible at the time without a lot of other work, though I forget the details.
| created_timestamp_seconds, | ||
| spawn_at_timestamp_seconds, | ||
| followees, | ||
| recent_ballots, |
There was a problem hiding this comment.
I think this is all you need to do to get the ballots in the right order here:
let recent_ballots = self.sorted_recent_ballots();
let Neuron {
...
recent_ballots: _,
...
} = self;
Rationale/Motivation
These values are derived. Hence, they do not need to be and should not be stored.
Overview
Got rid of
into_proto.Reintroduced
pb::Neuron::from.Added
into_api.Depending on the situation,
into_protocalls were replaced with eitherpb::Neuron::fromorinto_api. The difference is that the former is easier (requires less inputs), but the latter provides (deciding|potential)_voting_power.References
Closes NNS1-3500.