fix: [EXC-1836] Update hook status after update of canister settings #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragoljub-duric
commented
Jan 27, 2025
| call_id: _, | ||
| message: _, | ||
| instructions_used, | ||
| result, | ||
| } => (result, instructions_used, Some(canister)), | ||
| } => { | ||
| canister.update_on_low_wasm_memory_hook_condition(); |
There was a problem hiding this comment.
This is required to mimic the behavior of execute_install_code because execute_install_code updates hook status in the process_install_code result. The reason is that install_code is only used in tests, and should behave similarly.
dragoljub-duric
commented
Jan 27, 2025
dragoljub-duric
commented
Jan 27, 2025
dragoljub-duric
changed the title
dragoljub-duric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a check condition for the
low_wasm_memoryhook when canister settings are updated because changes ofwasm_memory_thresholdorwasm_memory_limitormemory_allocationcan trigger or un-trigger hook condition.