Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sns): Porting sns-testing to the ICP mono repo #3608

Closed
wants to merge 3 commits into from

Conversation

aterga
Copy link
Contributor

@aterga aterga commented Jan 24, 2025

TBD

Canister installation may fail due to insufficient cycles, so add cycles
before installing the canister in 'install_canister_with_controllers'.
The same is already done in 'install_canister_on_subnet'.
@rvem rvem force-pushed the rvem/sns-testing branch from 5174d92 to 5fd5048 Compare January 28, 2025 08:09
rvem added 2 commits January 28, 2025 15:25
Problem: NNS dapp needs ICP ledger index and Cycles minting canisters to be
deployed. Currently 'install_nns_canisters' doesn't install them.

Solution: Add 'install_nns_suite' helper that optionally installs ICP
ledger index and Cycles minting canisters. The existing
'install_nns_canisters' reuses 'install_nns_suite' but doesn't install
them.
Init the new sns-testing project.

Currently, this crate provides CLI to bootstrap NNS on the provided
PocketIC instance.
@rvem rvem force-pushed the rvem/sns-testing branch from 9964edb to f1fc5cb Compare January 28, 2025 14:25
@aterga
Copy link
Contributor Author

aterga commented Jan 28, 2025

Closing this PR as we decided to work against another branch, see #3654

@aterga aterga closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants