feat(ic-admin): Show the proposal URL for --dry-run #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified function signature of `parse_proposal_url` to accept a reference to `Option<Url>` instead of owning it, enhancing efficiency. - Updated all call sites of `parse_proposal_url` within `impl_proposal_metadata`, `propose_to_create_service_nervous_system`, `propose_to_add_or_remove_node_provider` to pass references. - Extended `print_proposal` function to include URL output, both in JSON serialization and direct printing.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
sasa-tomic
changed the title
sasa-tomic
dismissed
github-actions[bot]’s stale review
No canister behavior changes.
DFINITYManu
approved these changes
Jan 24, 2025
max-dfinity
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print_proposalto include URL information in its output.