chore(EXC-1840): Refactor bool to use WasmExecutionMode enum. #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-weigelt
approved these changes
Jan 28, 2025
pakhomov-dfinity
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
ExecutionStatewe were using aboolto represent whether a certain canister was executing in Wasm64 mode or not. In other places, such as theCyclesAccountManagerwe were using an enum that was cast from the bool. This PR refactors the usage of theboolparameter to using theWasmExecutionModeenum in all places. The only exception is the protobufs that are used for storing state on disk. For simplicity and compatibility we keep the bool representation there and we convert to the enum on serialization/deserialization.