Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate remaining items in api/call.rs #546

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Jan 14, 2025

Description

The DecoderConfig type in src/call.rs is removed since we have decoupled the decoder configuration from candid with Rust CDK by the decode_with macro option.

The ManualReply type is deprecated and developers can use PhantomData to wrap the update/query return type.
It is supported by this Candid PR dfinity/candid#591 which implemented CandidType for PhantomData.
So we need to have the Candid PR merged and released first. Then I'll update the candid dependency here.

is_recovering_from_trap was moved into futures.rs and re-exported in lib.rs.

How Has This Been Tested?

e2e-tests macros verified that PhantomData works well with manual_reply.
Other changes were mainly documentation and deprecation notes. No need to test.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang changed the base branch from main to next January 14, 2025 21:13
lwshang added a commit to dfinity/candid that referenced this pull request Jan 15, 2025
@lwshang lwshang marked this pull request as ready for review January 15, 2025 13:30
@lwshang lwshang requested a review from a team as a code owner January 15, 2025 13:30
@lwshang lwshang merged commit 710fc59 into next Jan 15, 2025
11 checks passed
@lwshang lwshang deleted the lwshang/SDK-1932_complete_deprecation_call branch January 15, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants