fix: Revert: Add serialization traits to Status #530
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a breaking change.
#499 added the CandidType, Serialize, and Deserialized traits to Status, in support of
dfx ping
to output json.However, Status isn't really appropriate for any of these. The
values
map contains every field in the status. But the other fields are populated during cbor deserialization. It's true that technically, you could serialize a Status and then deserialize it, even to and from candid. But when formatted to json, with the default serializer, a Status might look like this:This reverts commit f216c74(#499). We'll address the output of
dfx ping
in another way.How Has This Been Tested?
The reversion removed the related test.
Checklist: