-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump hyper to 1.0.1 #527
chore: bump hyper to 1.0.1 #527
Conversation
Is this prompted by something? Otherwise I would prefer to keep 0.14 until reqwest updates to hyper 1.0, so there is only one copy in the tree. |
This blocks bumping axum to 0.7 in icx-proxy. [BOUN-1008] |
ic-agent/Cargo.toml
Outdated
hyper-rustls = { version = "0.24.1", features = [ | ||
http-body-to-bytes = "0.2.0" | ||
http-body-util = "0.1.0" | ||
hyper-util = { version = "0.1.3", features = ["client", "client-legacy", "http2"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should all be optional dependencies too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added optional = true
to all of them if that's what you mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in, they should only be enabled when the hyper feature is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code does not build with --features hyper
.
What do you mean? The CI pipeline has succeeded and I could also successfully run |
Apologies for not adding detail - the new errors look like this:
Because the optional dependencies were not added to the hyper feature. I am not sure why it is succeeding on your local machine, you may be on a different commit, but it definitely does not succeed on mine. I am fixing the CI to detect this in #528. |
I could reproduce the build failure and fixed it now. |
This PR bumps hyper to 1.0.1.