feat: Add .Values.service.loadBalancerIP option #146
Merged
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorijn Schrijvershof <[email protected]>
jorijn
force-pushed
the
feat/loadbalancer-ip
branch
from
a57d86b to
867f55b
Compare
Signed-off-by: Jorijn Schrijvershof <[email protected]>
sagikazarmark
approved these changes
Jan 21, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add loadBalancerIP option to manually define an IP address when service type loadBalancer is defined.
What this PR does / why we need it
The helm chart currently has the option to define a service type but if service type is set to loadBalancer then there is no option to define a loadBalancerIP. The service type loadBalancer with loadBalancerIP option exposes the dex service externally with a defined load balancer IP for those instances where a load balancer IP cannot be assigned dynamically.
Special notes for your reviewer
Checklist