Skip to content

feat: mount file type variable in ci-runner through cm #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

feat: mount file type variable in ci-runner through cm #6537

merged 1 commit into from
May 4, 2025

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Apr 24, 2025 •
edited
Loading

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2110

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ash-exp Ash-exp self-assigned this Apr 24, 2025
@Ash-exp Ash-exp changed the base branch from main to hotfix-v0.33.0 April 25, 2025 10:10
@Ash-exp Ash-exp requested a review from pawan-mehta-dt as a code owner April 25, 2025 10:10
nishant-d
nishant-d previously approved these changes Apr 30, 2025
View reviewed changes
@Ash-exp Ash-exp changed the base branch from hotfix-v0.33.0 to hotfix-v0.34.0-precut April 30, 2025 09:37
@Ash-exp Ash-exp dismissed nishant-d’s stale review April 30, 2025 09:37

The base branch was changed.

@Ash-exp Ash-exp force-pushed the feat-file-variable-cm-mount branch from ad186c4 to 1afcd54 Compare April 30, 2025 09:50
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ash-exp Ash-exp merged commit 3730878 into hotfix-v0.34.0-precut May 4, 2025
6 checks passed
@Ash-exp Ash-exp deleted the feat-file-variable-cm-mount branch May 4, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@nishant-d nishant-d nishant-d left review comments

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

@pawan-mehta-dt pawan-mehta-dt Awaiting requested review from pawan-mehta-dt

Assignees

@Ash-exp Ash-exp

Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ash-exp @nishant-d @vikramdevtron