Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Usage - Suggestion #361

Merged
merged 14 commits into from
Feb 8, 2025
Merged

Conversation

vbakke
Copy link
Collaborator

@vbakke vbakke commented Jan 27, 2025

I have created a new Usage, that focuses on the first time user, giving a brief overview.

I have split up the existing USAGE.md into /usage/maturity-level-0 and /usage/dimensions.

A demo can be seen at https://dsomm.pages.dev/usage/.

Any comments, approvals and improvements are welcomed :)

@wurstbrot wurstbrot requested a review from 0x41head January 29, 2025 17:49
@wurstbrot
Copy link
Collaborator

wurstbrot commented Jan 29, 2025

Thank you, great work.

Before we add more code, please make sure that tests are not failing /see #355 (comment) /

@vbakke
Copy link
Collaborator Author

vbakke commented Jan 29, 2025

Thank you, great work.

Before we add more code, please make sure that tests are not failing /see #355 (comment) /

Sure. 0x41head's comment in #355 didn't tell me anything new, unfortunately. So I'm still on the same spot. Any hints for understanding Angular test regime for components would be greatly appreciated. :)

@wurstbrot
Copy link
Collaborator

@0x41head please review tests

@vbakke
Copy link
Collaborator Author

vbakke commented Feb 2, 2025

Thank you for approving the PR, @wurstbrot. I have not finished the INSTALL.md, yet, though. Do you want me to add that, and README adjustments to this PR, or create a new?

Copy link
Collaborator

@0x41head 0x41head left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to be working perfectly! Thanks!

@wurstbrot wurstbrot merged commit a6c3c26 into devsecopsmaturitymodel:master Feb 8, 2025
2 checks passed
@wurstbrot
Copy link
Collaborator

Thank you for approving the PR, @wurstbrot. I have not finished the INSTALL.md, yet, though. Do you want me to add that, and README adjustments to this PR, or create a new?

create new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants