Added control mechanisms for implemenation references #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension of PR #29. This PR is controlling references, and reports:
I have identified and tidied some duplicates in
implementations.yaml
(such asjuice-shop
,owasp-juice-shop
,zap
,owasp-zap
, etc).I have left two duplicate URLs issues. I presume they were supposed to link to to different pages, as the two references are both referred from the same activity.
Live URLs?
If you include the runtime environment variable
docker run -e TEST_REFERENCED_URLS=true ...
the script will now also loop through all URLs in theimplementations.yaml
and test if they are still alive.This is a bit more tricky, as websites such as https://thehackernews.com/ implement defenses against spiders. Therefore it this will report some false positives.
The current implementation reports any status not equal to 200. Including redirects such as 301 and 302.
Request for Comments
Please treat this as a Request-for-Comments, @wurstbrot. I'm open for discussion on several issues. For example: