Removed manual worker path mapping from the template - #60
Merged
Conversation
gasperzgonec
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the extraction function to use the new getWorkerPath functionality from the @devrev/ts-adaas SDK (v1.13.0). The change simplifies worker path resolution by replacing a manual event type switch statement with the SDK's internal worker path handling.
Key Changes:
- Removed manual worker path mapping logic (
getWorkerPerExtractionPhasefunction) - Updated
spawnfunction to usebaseWorkerPathparameter instead ofworkerPath - Upgraded
@devrev/ts-adaasdependency from 1.12.2 to 1.13.0
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| code/src/functions/extraction/index.ts | Removed manual worker path resolution function and updated spawn call to use baseWorkerPath |
| code/package.json | Upgraded @devrev/ts-adaas dependency to version 1.13.0 |
Files not reviewed (1)
- code/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
radovanjorgic
previously approved these changes
Dec 17, 2025
radovanjorgic
left a comment
radovanjorgic
left a comment
Contributor
There was a problem hiding this comment.
Bump SDK version, otherwise LG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I updated the template to use the new "internal" SDK
getWorkerPath, by simply removing the manual mapping and adding the argument to the spawn function call.Connected Issues
Checklist
npm run testOR no tests needed.npm run lint.