enh: Add IDM version to template - #44
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a versioning system to the Initial Domain Mapping (IDM) by adding a format_version field set to "v0.2.0". This change enables the chef-cli tool to understand different IDM format versions and handle backwards compatibility appropriately.
- Adds
format_versionfield with value "v0.2.0" to the IDM JSON structure - Fixes JSON syntax by adding missing comma after the closing brace
Comments suppressed due to low confidence (1)
code/src/functions/external-system/initial_domain_mapping.json:153
- The comma after the closing brace appears to be fixing a JSON syntax error from the previous structure, but this suggests the original JSON was malformed. Ensure the entire JSON structure is valid after this change.
},
B-Lorentz
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This introduces the new IDM versioning system.
After this is merged I will release chef-cli 0.8.0, which will support this format but will assume v0.1.0 if no version is provided. Template repo should default the users to the latest version.
DevRev issue
https://app.devrev.ai/devrev/works/ISS-188976
Documentation PR
I'll document this in the GitHub release as well as announcement, documentation PR will come later.