Update specification to include attachments and rate limiting #7
Conversation
patricijabrecko
force-pushed
the
updated-spec
branch
from
c5f3808 to
4073bb6
Compare
Co-authored-by: Tjaž Eržen <[email protected]>
patricijabrecko
force-pushed
the
updated-spec
branch
from
817f249 to
8f4d516
Compare
devrev-wrike-snapin.plain
Outdated
| - If "event_type" equals "EXTRACTION_DATA_START" or "EXTRACTION_DATA_CONTINUE" The Extraction Function should push the 'tasks' and 'users' data. To push the 'tasks' data, it should: | ||
| - If `TheExtractionStateObject["tasks"]["completed"]=false`: | ||
| - While Fetching The Fetched Tasks using pagination (The Tasks Iteration): | ||
| - When fetching The Fetched Tasks use the query param 'fields', where the value is an array of strings, which contains at least 'hasAttachments'. |
There was a problem hiding this comment.
I think this still have to be adjusted to comment made in the previous review iteration.
There was a problem hiding this comment.
But I think this is described correctly - it has to at least contain 'hasAttachments', can also contain other values. Depends on the use case.
There was a problem hiding this comment.
If I limit it here to contain only 'hasAttachments' it will be in conflict with other FRs.
There was a problem hiding this comment.
I suggest you phrase which contains at least 'hasAttachments'. less ambiguously as we discussed, and render. I understand you got a conflict earlier. I think we should get to the root cause of the problem why a conflict exists, and then resolve it.
patricijabrecko
force-pushed
the
updated-spec
branch
from
8f4d516 to
7bf1bef
Compare
There was a problem hiding this comment.
Alright 👍
Let's finish it tomorrow, but here are the things you can do right away:
- final touches for
mappings/folder - Minor updates to
test_data/folder
Also, I'm missing the updates for the new templating:
- every file from
mappings/folder - Correct templating of
templates/chef_cli_normalization_validation.plainindevrev-wrike-snapin.plain
devrev-wrike-snapin.plain
Outdated
| - If "event_type" equals "EXTRACTION_DATA_START" or "EXTRACTION_DATA_CONTINUE" The Extraction Function should push the 'tasks' and 'users' data. To push the 'tasks' data, it should: | ||
| - If `TheExtractionStateObject["tasks"]["completed"]=false`: | ||
| - While Fetching The Fetched Tasks using pagination (The Tasks Iteration): | ||
| - When fetching The Fetched Tasks use the query param 'fields', where the value is an array of strings, which contains at least 'hasAttachments'. |
There was a problem hiding this comment.
I suggest you phrase which contains at least 'hasAttachments'. less ambiguously as we discussed, and render. I understand you got a conflict earlier. I think we should get to the root cause of the problem why a conflict exists, and then resolve it.
2 participants
No description provided.